Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Fix table markup in Design Language - Radius docs #67686

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Dec 6, 2024

What?

Fixes a warning in the Design Language - Radius docs.

Why?

Just fixing a warning in the Storybook design system docs.

Found while working on #67574.

How?

We're adding thead and tbody sections, respectively.

Testing Instructions

Testing Instructions for Keyboard

Same

Screenshots or screencast

Error before this PR:

Screenshot 2024-12-06 at 12 15 58

@tyxla tyxla added [Type] Enhancement A suggestion for improvement. Storybook Storybook and its stories for components labels Dec 6, 2024
@tyxla tyxla requested review from Mamaduka, jameskoster, t-hamano and a team December 6, 2024 10:17
@tyxla tyxla self-assigned this Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Dec 6, 2024

Flaky tests detected in 5f76024.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12197025229
📝 Reported issues:

@tyxla tyxla merged commit bad9281 into trunk Dec 6, 2024
71 of 73 checks passed
@tyxla tyxla deleted the improve/design-language-radius-docs-table branch December 6, 2024 12:07
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants